Re: [PATCH] SiS190/191 half-duplex initialization fix From: David Miller <davem@davemloft.net> Date: 2010-02-16 22:47:41 From: Riccardo Ghetta <redacted> Date: Mon, 15 Feb 2010 21:19:00 +0100 + u32 negotiated_lpa; Uses spaces instead of tabs. + tp->negotiated_lpa = p->val; Has a space then tabs, should be all tab characters. + if (tp->negotiated_lpa & (LPA_1000HALF | LPA_100HALF | LPA_10HALF)) + { Should be: if (condition) { ie. the openning brace need to be on the same line as the if statement. Please fix these issues up and resubmit your patch, thanks.
Keyboard shortcuts hback out one level jnext message in thread kprevious message in thread ldrill in Escclose help / fold thread tree ?toggle this help