Thread (42 messages) 42 messages, 6 authors, 2010-02-18

Re: [PATCH v2] net/macvtap: fix reference counting

From: Ed Swierk <hidden>
Date: 2010-02-12 20:58:10

On Thu, Feb 11, 2010 at 7:55 AM, Arnd Bergmann [off-list ref] wrote:
The RCU usage in the original code was broken because
there are cases where we possibly sleep with rcu_read_lock
held. As a fix, change the macvtap_file_get_queue to
get a reference on the socket and the netdev instead of
taking the full rcu_read_lock.

Also, change macvtap_file_get_queue failure case to
not require a subsequent macvtap_file_put_queue, as
pointed out by Ed Swierk.
Works for me. Thanks.

Acked-by: Ed Swierk <redacted>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help