Re: [PATCH 02/11] fs_enet: Add FEC TX Alignment workaround for MPC5121
From: Wolfram Sang <hidden>
Date: 2010-01-20 10:22:33
Also in:
linuxppc-dev
quoted hunk ↗ jump to hunk
diff --git a/drivers/net/fs_enet/fs_enet-main.c b/drivers/net/fs_enet/fs_enet-main.c index 909b78d..a391219 100644 --- a/drivers/net/fs_enet/fs_enet-main.c +++ b/drivers/net/fs_enet/fs_enet-main.c@@ -587,6 +587,33 @@ void fs_cleanup_bds(struct net_device *dev) /**********************************************************************************/ +static struct sk_buff *tx_skb_align_workaround(struct net_device *dev, + struct sk_buff *skb) +{ + struct sk_buff *new_skb; + + /* Alloc new skb */ + new_skb = dev_alloc_skb(ENET_RX_FRSIZE + 32); + if (!new_skb) { + printk(KERN_WARNING DRV_MODULE_NAME + ": %s Memory squeeze, dropping tx packet.\n", + dev->name);
I understand this type of printk fits to the rest of the code, I just wonder if new (and patched) printouts shouldn't be converted to dev_*? Might be one line then, and more consistent to what other drivers produce. -- Pengutronix e.K. | Wolfram Sang | Industrial Linux Solutions | http://www.pengutronix.de/ |
Attachments
- signature.asc [application/pgp-signature] 197 bytes