Re: [PATCH 1/2] IPv6: conntrack: Use protocol-related initialization routine to initial queues of IPv6 connection track
From: David Miller <davem@davemloft.net>
Date: 2010-01-26 13:11:47
Also in:
netfilter-devel
From: David Miller <davem@davemloft.net>
Date: 2010-01-26 13:11:47
Also in:
netfilter-devel
From: Patrick McHardy <redacted> Date: Tue, 26 Jan 2010 13:46:46 +0100
Oops, sorry. Not sure why I missed this, I've successfully tested that change multiple times.
This situation is error prone, and I don't blame you for not catching it, because these common ipv6 fragmentation functions are assuming things about the layout of the first few struct members of the container in which the top level data structure lives. What should happen is that when such an assumption exists, it should be explicitly codified. Just like how we embed struct sock_common in both struct socket and in the TCP time-wait minisockets. Anyways, meanwhile I'll apply the fix. And yes I know it needs to go to stable too... :-)