Thread (4 messages) 4 messages, 2 authors, 2010-01-25

Re: [PATCH 1/1 V3] net: Add Aeroflex Gaisler 10/100/1G Ethernet MAC driver

From: David Miller <davem@davemloft.net>
Date: 2010-01-23 10:05:41

From: Kristoffer Glembo <redacted>
Date: Fri, 22 Jan 2010 13:51:17 +0100
Adds device driver for Aeroflex Gaisler 10/100 and 10/100/1G Ethernet MAC IP cores.

Signed-off-by: Kristoffer Glembo <redacted>
Generates build warnings, please fix:

drivers/net/greth.c: In function ‘greth_rx’:
drivers/net/greth.c:781: warning: passing argument 1 of ‘greth_print_rx_packet’ makes integer from pointer without a cast
drivers/net/greth.c: In function ‘greth_rx_gbit’:
drivers/net/greth.c:885: warning: passing argument 1 of ‘greth_print_rx_packet’ makes integer from pointer without a cast

phys_to_virt() give a virtual address pointer, so this should
have generated warnings on 64-bit as well as 32-bit systems.

I can't see how you could have possibly build tested this and
not seen the warnings.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help