Thread (21 messages) 21 messages, 7 authors, 2010-01-28

Re: [PATCH v5] rps: Receive Packet Steering

From: Eric Dumazet <hidden>
Date: 2010-01-21 09:16:29

Le 21/01/2010 08:54, Changli Gao a écrit :
Sometimes, rxhash will be 0 generated. In order to check whether
rxhash is generated or not, a new bit field in sk_buff is needed. When
rxhash is generated and saved in sk_buff, the bit is set.

And, I think rxhash should be reserved when calling skb_copy and skb_clone.
I disagree

A null rxhash should not be generated by a driver, or even if its null,
why should we care ?

In this very unlikely event, let get_rps_cpu() compute a (non null) hash.

Adding a bit in skb for such low probability event brings nothing but complexity.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help