Re: [PATCH] sky2: Lock transmit queue while disabling device
From: David Miller <davem@davemloft.net>
Date: 2010-01-07 08:19:15
From: David Miller <davem@davemloft.net>
Date: 2010-01-07 08:19:15
From: Jarek Poplawski <redacted> Date: Thu, 7 Jan 2010 08:15:01 +0000
Maybe right, but Mike's patch changelog above writes: "Proposed fix for "sky2 panic under load" reported by Berck E. Nash.", and maybe I missed something, but I can't find any report which acknowledges this patch fixed this or down/suspending problem.
Certainly by my reading Mike's patch does in fact fix a race between device detach and the TX handler, so regardless of whether it fixes actual reported user problems it should at a minimum go into net-next-2.6 And that's _exactly_ what I did, and how I analyzed his work.