Thread (16 messages) 16 messages, 5 authors, 2010-01-04

Re: [PATCH] dmfe/tulip: Let dmfe handle DM910x except for SPARC on-board chips

From: David Miller <davem@davemloft.net>
Date: 2010-01-04 05:36:26

From: Grant Grundler <redacted>
Date: Tue, 29 Dec 2009 11:41:52 -0700
On Tue, Dec 29, 2009 at 06:22:28PM +0000, Ben Hutchings wrote:
quoted
The Davicom DM9100 and DM9102 chips are used on the motherboards of
some SPARC systems (supported by the tulip driver) and also in PCI
expansion cards (supported by the dmfe driver).  There is no
difference in the PCI device ids for the two different configurations,
so these drivers both claim the device ids.  However, it is possible
to distinguish the two configurations by the presence of Open Firmware
properties for them, so we do that.

Signed-off-by: Ben Hutchings <redacted>
Acked-by: Grant Grundler <redacted>

I've reviewed the code and it looks fine to me.

Only thing I'm not sure about is if "KERN_ERR" is
the right priority for what are essentially warning
messages. Not harmful. But could be annoying to some
Sparc users who get this on every boot when both modules
are present and loaded in the "wrong" order.
I agree, KERN_INFO is more appropriate here.

Also, for the of_get_property() calls, you don't need to pass
in a dummy "&len", just pass NULL.  This will avoid the dummy
local variable 'len'.

Make these two fixups and I'll apply this to net-2.6

Thanks!
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help