Thread (3 messages) 3 messages, 3 authors, 2009-12-30

Re: [PATCH] drivers/atm/lanai.c: use %pM to show MAC address

From: Joe Perches <joe@perches.com>
Date: 2009-12-30 18:59:49
Also in: lkml

On Wed, 2009-12-30 at 13:50 -0500, H Hartley Sweeten wrote:
quoted hunk ↗ jump to hunk
Use the %pM kernel extension to display the MAC address.
diff --git a/drivers/atm/lanai.c b/drivers/atm/lanai.c
index cf97c34..7fe7c32 100644
--- a/drivers/atm/lanai.c
+++ b/drivers/atm/lanai.c
[]
quoted hunk ↗ jump to hunk
@@ -2483,14 +2481,8 @@ static int lanai_proc_read(struct atm_dev *atmdev, loff_t *pos, char *page)
 		return sprintf(page, "revision: board=%d, pci_if=%d\n",
 		    lanai->board_rev, (int) lanai->pci->revision);
 	if (left-- == 0)
-		return sprintf(page, "EEPROM ESI: "
-		    "%02X:%02X:%02X:%02X:%02X:%02X\n",
-		    lanai->eeprom[EEPROM_MAC + 0],
-		    lanai->eeprom[EEPROM_MAC + 1],
-		    lanai->eeprom[EEPROM_MAC + 2],
-		    lanai->eeprom[EEPROM_MAC + 3],
-		    lanai->eeprom[EEPROM_MAC + 4],
-		    lanai->eeprom[EEPROM_MAC + 5]);
+		return sprintf(page, "EEPROM ESI: %pM\n",
+		    &lanai->eeprom[EEPROM_MAC]);
This is a user-visible change from upper case to lower case.
Probably doesn't matter, but maybe...
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help