Re: [PATCH 4/5] drivers/net/can: Correct NULL test
From: Oliver Hartkopp <socketcan@hartkopp.net>
Date: 2009-12-28 13:50:08
Also in:
kernel-janitors, lkml
Julia Lawall wrote:
From: Julia Lawall <redacted>
Thanks Julia! I added Christian Pellegrin who is the author of this driver in CC. An obvious copy/paste error :-) Regards, Oliver Acked-by: Oliver Hartkopp <redacted>
quoted hunk ↗ jump to hunk
Test the just-allocated value for NULL rather than some other value. The semantic patch that makes this change is as follows: (http://coccinelle.lip6.fr/) // <smpl> @@ expression x,y; statement S; @@ x = \(kmalloc\|kcalloc\|kzalloc\)(...); ( if ((x) == NULL) S | if ( - y + x == NULL) S ) // </smpl> Signed-off-by: Julia Lawall <redacted> --- drivers/net/can/mcp251x.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff -u -p a/drivers/net/can/mcp251x.c b/drivers/net/can/mcp251x.c--- a/drivers/net/can/mcp251x.c +++ b/drivers/net/can/mcp251x.c@@ -990,7 +990,7 @@ static int __devinit mcp251x_can_probe(s goto error_tx_buf; } priv->spi_rx_buf = kmalloc(SPI_TRANSFER_BUF_LEN, GFP_KERNEL); - if (!priv->spi_tx_buf) { + if (!priv->spi_rx_buf) { ret = -ENOMEM; goto error_rx_buf; } --To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html