Re: warning: massive change to conditional coding style in net?
From: Eric Dumazet <hidden>
Date: 2009-12-01 18:30:15
Also in:
lkml
William Allen Simpson a écrit :
If these changes had been mentioned a month or two ago, as part of a thorough review, it could have been discussed earlier. Instead, it's like being nibbled by mice.
William, This is absolutely _not_ possible to comment a 1000+ lines patches in one shot, being your patch or not. It would take _hours_ of work, even for David. We use a step-by-step process, with limited feedbacks, because nobody is paid to make your life easier. We patiently gave you a lot of advices and yet you complain again and again. After 15/30 minutes of reviewing patches, and collecting some suggestions, the average reviewer stops its review, sends a feedback, and waits for next patch submission. [hoping patch author will be pro_active and check all its patches, not the precise points that were specificaly raised.] Yes, sometime we notice a point at round eleven, instead of first/second round, because more important things were noticed at prior rounds. I honestly hope you change your mind, or I wont even read your next patch submissions, wait for the official RFC and code the damn thing myself or wait for some kind developper willing to do the job, in the normal process. You can copy this mail to all man kind, it wont make your patches magically ready for inclusion. Respectfully, Eric