Thread (1 message) 1 message, 1 author, 2009-11-11

Re: [PATCH 13/13] pcmcia: rework the irq_req_t typedef

From: Marcel Holtmann <hidden>
Date: 2009-11-11 20:46:03
Also in: alsa-devel, linux-bluetooth, linux-ide, linux-scsi, linux-wireless

Hi Dominik,
Most of the irq_req_t typedef'd struct can be re-worked quite
easily:

(1) IRQInfo2 was unused in any case, so drop it.

(2) IRQInfo1 was used write-only, so drop it.

(3) Instance (private data to be passed to the IRQ handler):
	Most PCMCIA drivers using pcmcia_request_irq() to actually
	register an IRQ handler set the "dev_id" to the same pointer
	as the "priv" pointer in struct pcmcia_device. Modify the two
	exceptions (ipwireless, ibmtr_cs) to also work this waym and
	set the IRQ handler's "dev_id" to p_dev->priv unconditionally.

(4) Handler is to be of type irq_handler_t.

(5) Handler != NULL already tells whether an IRQ handler is present.
	Therefore, we do not need the IRQ_HANDLER_PRESENT flag in
	irq_req_t.Attributes.

CC: netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
CC: linux-bluetooth-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
CC: linux-ide-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
CC: linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
CC: linux-scsi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
CC: alsa-devel-K7yf7f+aM1XWsZ/bQMPhNw@public.gmane.org
CC: Jaroslav Kysela <perex-/Fr2/VpizcU@public.gmane.org>
CC: Jiri Kosina <redacted>
CC: Karsten Keil <redacted>
Signed-off-by: Dominik Brodowski <redacted>
---
 drivers/ata/pata_pcmcia.c                        |    1 -
 drivers/bluetooth/bluecard_cs.c                  |    4 +---
 drivers/bluetooth/bt3c_cs.c                      |    4 +---
 drivers/bluetooth/btuart_cs.c                    |    4 +---
 drivers/bluetooth/dtl1_cs.c                      |    4 +---
for the Bluetooth parts:

Acked-by: Marcel Holtmann <redacted>

Regards

Marcel
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help