Re: [PATCH] net: Fix checks on unsigned in w90p910_ether_probe()
From: Wan ZongShun <hidden>
Date: 2009-10-30 06:18:36
Also in:
linux-arm-kernel
From: Wan ZongShun <hidden>
Date: 2009-10-30 06:18:36
Also in:
linux-arm-kernel
Dear sirs, Okay, it is right, thanks all for your help. I will re-fix it later. 2009/10/30, David Miller [off-list ref]:
From: Roel Kluin <redacted> Date: Tue, 20 Oct 2009 20:14:36 +0200quoted
ether->txirq and ->rxirq are unsigned Signed-off-by: Roel Kluin <redacted>platform_get_irq() returns a signed int so the intention is more likely that catching negative value returns was intended. Probably the correct fix is to mark txirq and rxirq as plain 'int'.
-- Wan z.s