RE: [Pv-drivers] [PATCH -next] vmxnet3: use dev_dbg, fix build for CONFIG_BLOCK=n

From: Dmitry Torokhov [mailto:dtor@vmware.com]
Sent: Thursday, October 15, 2009 3:48 PM
To: pv-drivers@vmware.com
Cc: Randy Dunlap; Bhavesh Davda; Stephen Rothwell; netdev; LKML; linux-
next@vger.kernel.org; David Miller
Subject: Re: [Pv-drivers] [PATCH -next] vmxnet3: use dev_dbg, fix build
for CONFIG_BLOCK=n

Hi Randy,

On Thursday 15 October 2009 03:42:49 pm Randy Dunlap wrote:

quoted

Bhavesh Davda wrote:

quoted

Who ever compiles with CONFIG_BLOCK=n? Just kidding...

or why does networking need CONFIG_BLOCK at all?  ;)

quoted

Thanks again for making this change! Ship it!

So could I have used adapter->netdev->dev or adapter->pdev->dev ?
either of them?  are they the same?

They are the same.

Right:

vmxnet3_probe_device(struct pci_dev *pdev,...)

	struct net_device *netdev;
	...
	netdev = alloc_etherdev(sizeof(struct vmxnet3_adapter));
	...
	pci_set_drvdata(pdev, netdev);
	adapter = netdev_priv(netdev);
	adapter->netdev = netdev;
	adapter->pdev = pdev;

- Bhavesh