Thread (10 messages) flat view 10 messages, 4 authors, 2009-10-15

Re: [Bug #14378] Problems with net/core/skbuff.c

From: Massimo Cetra <hidden>
Date: 2009-10-14 19:28:22
Also in: lkml

Massimo Cetra ha scritto:
Eric Dumazet ha scritto:
quoted
Could you please following patch ?
diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c
index 8d00976..54bf091 100644
--- a/drivers/net/virtio_net.c
+++ b/drivers/net/virtio_net.c
@@ -454,7 +454,7 @@ static unsigned int free_old_xmit_skbs(struct 
virtnet_info *vi)
         vi->dev->stats.tx_bytes += skb->len;
         vi->dev->stats.tx_packets++;
         tot_sgs += skb_vnet_hdr(skb)->num_sg;
-        kfree_skb(skb);
+        dev_kfree_skb_any(skb);
     }
     return tot_sgs;
 }


  
Thank you very much.

Compiling.
It' will be in production in a few minutes.
I'll let you know if the problem arises again.
give me a couple of days because this problem is randomly triggered.
Sometimes it happens multiple times a day, sometimes none.
Eric,
thanks for the patch.
The problem didn't arise again and i haven't seen any warning like that 
on both servers where that problem was happening more frequently.

I would say that it's fixed and if it's not, i'll let you know as soon 
as it happens again.

Thanks again,
Max
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help