Re: [PATCH 2.6.32-rc1] net: VMware virtual Ethernet NIC driver: vmxnet3
From: Stephen Hemminger <hidden>
Date: 2009-10-01 00:39:22
Also in:
lkml
From: Stephen Hemminger <hidden>
Date: 2009-10-01 00:39:22
Also in:
lkml
On Wed, 30 Sep 2009 14:34:57 -0700 (PDT) Shreyas Bhatewara [off-list ref] wrote: Note: your patch was linewrapped again
+
+
+static void
+vmxnet3_declare_features(struct vmxnet3_adapter *adapter, bool dma64)
+{
+ struct net_device *netdev = adapter->netdev;
+
+ netdev->features = NETIF_F_SG |
+ NETIF_F_HW_CSUM |
+ NETIF_F_HW_VLAN_TX |
+ NETIF_F_HW_VLAN_RX |
+ NETIF_F_HW_VLAN_FILTER |
+ NETIF_F_TSO |
+ NETIF_F_TSO6;
+
+ printk(KERN_INFO "features: sg csum vlan jf tso tsoIPv6");
+
+ adapter->rxcsum = true;
+ adapter->jumbo_frame = true;
+
+ if (!disable_lro) {
+ adapter->lro = true;
+ printk(" lro");
+ }Why not use NETIF_F_LRO and ethtool to control LRO support?