Re: [PATCH net-next-2.6] veth: Fix veth_dellink method
From: Eric W. Biederman <hidden>
Date: 2009-10-30 23:07:51
Eric Dumazet [off-list ref] writes:
quoted hunk ↗ jump to hunk
In commit 23289a37e2b127dfc4de1313fba15bb4c9f0cd5b (net: add a list_head parameter to dellink() method), I forgot to actually use this parameter in veth_dellink. I remember feeling a bit uncomfortable about veth_close(), because it does : netif_carrier_off(dev); netif_carrier_off(priv->peer); Signed-off-by: Eric Dumazet <redacted> ---diff --git a/drivers/net/veth.c b/drivers/net/veth.c index ffb502d..9bed694 100644 --- a/drivers/net/veth.c +++ b/drivers/net/veth.c@@ -450,8 +450,8 @@ static void veth_dellink(struct net_device *dev, struct list_head *head) priv = netdev_priv(dev); peer = priv->peer; - unregister_netdevice(dev); - unregister_netdevice(peer); + unregister_netdevice_queue(dev, head); + unregister_netdevice_queue(peer, head);
Unless I am mistaken you need to change the list_add_tail to list_move_tail in unregister_netdevice_queue because we will be adding each veth device twice. Eric