On 21:12 Thu 29 Oct 2009, David Miller wrote:

From: Brandon Philips <redacted>
Date: Thu, 29 Oct 2009 20:51:28 -0700

quoted

The right thing to do is up the interface first before looking at the
the Link state, and I told them to do that, but I figured that this
patch made sense too to fix the initial buglet.

It is not valid to expect link status before bringing the interface
up.

I agree the link state makes no sense when the interface isn't up.
The buglet is that other drivers seem to report "Link detected: no"
after probe while sky2 doesn't.

I don't have a strong feeling on this patch since the customer fixed
their script to do the right thing.

Cheers,

	Brandon