Re: [PATCH] net: fix kmemcheck annotations
From: David Miller <davem@davemloft.net>
Date: 2009-10-29 10:17:24
From: David Miller <davem@davemloft.net>
Date: 2009-10-29 10:17:24
From: Eric Dumazet <redacted> Date: Thu, 29 Oct 2009 11:10:37 +0100
@@ -367,7 +367,6 @@ struct sk_buff { #endif int iif; - __u16 queue_mapping; #ifdef CONFIG_NET_SCHED __u16 tc_index; /* traffic control index */ #ifdef CONFIG_NET_CLS_ACT@@ -376,6 +375,7 @@ struct sk_buff { #endif kmemcheck_bitfield_begin(flags2); + __u16 queue_mapping:16; #ifdef CONFIG_IPV6_NDISC_NODETYPE __u8 ndisc_nodetype:2; #endif
We may be trading size for performance here, I wonder if it's wise to move queue_mapping like that and what locality change we get as a result.