Thread (8 messages) 8 messages, 4 authors, 2009-10-30

Re: [PATCH] net: Fix RPF to work with policy routing

From: Maciej Żenczykowski <hidden>
Date: 2009-10-23 06:30:16

In most of the use cases I've seen marking packets has been far from
symmetric (of course: not that this is representative of anything).
Although, to be fair, most of the time this is because packets in only
direction (usually trasmit) were even being marked in the first place.

However, I do agree that .mark should be explicitly initialized (or a
comment about it being left =0 inserted in the same location).

On Thu, Oct 22, 2009 at 21:49, David Miller [off-list ref] wrote:
From: jamal <redacted>
Date: Sun, 18 Oct 2009 08:13:39 -0400
quoted
On Sun, 2009-10-18 at 08:12 -0400, jamal wrote:
quoted
policy routing never worked with mark.
I meant policy routing, mark and RPF never worked together ;->
Is this actually valid?

Such a change has a built-in assumption, I think, that
marks are symmetric.

Just because we ended up with mark X on input doesn't mean
that the reverse path route exists with mark X too.

In fact I can't even see a valid way to specify a mark for
the RPF lookup.

Maybe you can convince me otherwise :-)
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help