Re: [PATCH 2/4 v2] net: Use sk_tx_queue_mapping for connected sockets

Hi Eric,

Eric Dumazet [off-list ref] wrote on 10/16/2009 07:37:30 PM:

quoted

I wait for tcp_v4_syn_recv_sock to finish and create a connection.
sk_setup_caps/__sk_dst_set are called for the new socket resulting
in sk_dst_cache getting set (I cannot set the cache till the
connection is finished and dst is set). I guess that means that I
will wait for another skb to come and the response will use skb_tx_hash
instead of using the rx recorded.

Well, I see no relation between rx mapping and tx mapping currently.

You are suggesting an enhancement to assign the txq# at ack processing
using the skb->rx#. As you said it will help cards that are hashing the
rx# internally. I will try that separately after this patch.

quoted

Will this suffice, but if not, is it something I should handle or an
add-on patch should do instead?

Your patch is fine, I was only giving ideas for future patches :)

Thanks for the suggestions, I just wanted to make sure.

- KK