(off-list ancestor, not in this archive)
Re: [PATCH] ax25: unsigned cannot be less than 0 in ax25_ctl_ioctl() · Roel Kluin <hidden> · 2009-10-12
Re: [PATCH] ax25: unsigned cannot be less than 0 in ax25_ctl_ioctl() · Kevin Dawson <hidden> · 2009-10-12
Re: [PATCH] ax25: unsigned cannot be less than 0 in ax25_ctl_ioctl() · walter harms <hidden> · 2009-10-13
Re: [PATCH] ax25: unsigned cannot be less than 0 in ax25_ctl_ioctl() · Kevin Dawson <hidden> · 2009-10-13
Re: [PATCH] ax25: unsigned cannot be less than 0 in ax25_ctl_ioctl() · Roel Kluin <hidden> · 2009-10-14
Re: [PATCH] ax25: unsigned cannot be less than 0 in ax25_ctl_ioctl() · David Miller <davem@davemloft.net> · 2009-10-30

Re: [PATCH] ax25: unsigned cannot be less than 0 in ax25_ctl_ioctl()

From: Kevin Dawson <hidden>
Date: 2009-10-12 22:24:32
Also in: linux-hams

Possibly related (same subject, not in this thread)

2009-10-10 · [PATCH] ax25: unsigned cannot be less than 0 in ax25_ctl_ioctl() · Roel Kluin <hidden>

Roel Kluin wrote:

quoted

 tmp_arg=ax25_ctl.arg * HZ;

  if (arg == 0 || arg >  ULONG_MAX )
		goto einval_put;

I'm not sure, I think this would only work if we made `arg' an
unsigned long long.

That depends on the possible values of ax25_ctl.arg.

+	if (ax25_ctl.arg * HZ > ULONG_MAX && ax25_ctl.cmd != AX25_KILL)
+		return -EINVAL;

Why the need to change arg before comparing it with a constant?  Let the 
compiler do the work:

	if (ax25_ctl.arg > ULONG_MAX / HZ && ...

Kevin