Thread (2 messages) flat view 2 messages, 2 authors, 2009-10-05

Re: [PATCH] icmp: No need to call sk_write_space()

From: David Miller <davem@davemloft.net>
Date: 2009-10-05 07:12:15

From: Eric Dumazet <redacted>
Date: Fri, 25 Sep 2009 00:16:51 +0200
We can make icmp messages tx completion callback a litle bit faster.

Setting SOCK_USE_WRITE_QUEUE sk flag tells sock_wfree() to
not call sk_write_space() on a socket we know no thread is posssibly
waiting for write space. (on per cpu kernel internal icmp sockets only)

This avoids the sock_def_write_space() call and 
read_lock(&sk->sk_callback_lock)/read_unlock(&sk->sk_callback_lock) calls
as well.

We avoid three atomic ops.

Signed-off-by: Eric Dumazet <redacted>
Applied to net-next-2.6
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help