Thread (18 messages) 18 messages, 7 authors, 2009-09-30

Re: [Pv-drivers] [PATCH 2.6.31-rc9] net: VMware virtual Ethernet NIC driver: vmxnet3

From: David Miller <davem@davemloft.net>
Date: 2009-09-29 19:55:13
Also in: lkml

From: Bhavesh Davda <redacted>
Date: Tue, 29 Sep 2009 12:52:05 -0700
quoted
One thing that should possibly be fixed is the naming of identifiers,
e.g.
's/Vmxnet3_MiscConf/vmxnet3_misc_conf/g', unless these header files are
shared with the host implementation.
These header files are indeed shared with the host implementation, as you've guessed. If it's not a big deal, we would like to keep the names the same, just for our own sanity's sake?
No.  This isn't your source tree, it's everyone's.  So you should
adhere to basic naming conventions and coding standards of the
tree regardless of what you happen to use or need to use internally.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help