On Sun, 27 Sep 2009 17:14:04 +0100 (BST)
Hugh Dickins [off-list ref] wrote:

On Sun, 27 Sep 2009, Arjan van de Ven wrote:

quoted

With todays git my laptop fails to associate with my access point.
Bisection points to the commit below, and reverting this one commit
on the HEAD of tree also fixes the issue, so I'm pretty confident
that this commit is to blame.

I have a 4965 wifi card in my laptop, and the network I'm trying to
connect to has no encryption. I'm running Fedora 11 as OS.

I would like to kindly request for this commit to be reverted until
a more permanent solution is found (I'm happy to test any patches)..

94f85853324e02c3a32bc3101f090dc9a3f512b4 is first bad commit
commit 94f85853324e02c3a32bc3101f090dc9a3f512b4
Author: Johannes Berg [off-list ref]
Date:   Thu Sep 17 17:15:31 2009 -0700

    cfg80211: don't overwrite privacy setting
    
    When cfg80211 is instructed to connect, it always
    uses the default WEP key for the privacy setting,
    which clearly is wrong when using wpa_supplicant.
    Don't overwrite the setting, and rely on it being
    false when wpa_supplicant is not running, instead
    set it to true when we have keys.
    
    Signed-off-by: Johannes Berg [off-list ref]
    Signed-off-by: John W. Linville [off-list ref]

:040000 040000 27fb46273e88eefee373699eb7e3f2923ac0886b
9518ee3e52c8320613cc5eee5ac54aabf082432f M	net

I've a different problem with wireless that Johannes is investigating
for me on linux-wireless; but here's a patch that he pointed me to
along the way, didn't help my issue but I expect it will help yours...


Subject: cfg80211: don't set privacy w/o key

When wpa_supplicant is used to connect to open networks,
it causes the wdev->wext.keys to point to key memory, but
that key memory is all empty. Only use privacy when there
is a default key to be used.

indeed it does

can we get this into mainline soon ?