On Sat, 2009-09-26 at 12:03 -0700, kxie@chelsio.com wrote:

 enum {                 /* rx_offload flags */
        T3_RX_CSUM      = 1 << 0,
        T3_LRO          = 1 << 1,
 };
 
+enum {
+       LAN_MAC_IDX     = 0,
+       SAN_MAC_IDX,
+
+       MAX_MAC_IDX
+};

Why not name the enum and use it in the function declarations? I see
there are some other unnamed enums in there so you are following the
style in the file already.. However, naming the enum and using it allows
the input values to be known instead of just saying "int n", so I think
that's a better method..

Daniel