Thread (10 messages) 10 messages, 5 authors, 2009-09-04

Re: [PATCH resend] tracing/events: convert NAPI's tracepoint via TRACE_EVENT

From: David Miller <davem@davemloft.net>
Date: 2009-09-02 01:26:32
Also in: lkml

From: Steven Rostedt <rostedt@goodmis.org>
Date: Mon, 31 Aug 2009 14:09:04 -0400 (EDT)
On Mon, 31 Aug 2009, Ingo Molnar wrote:
quoted
* Xiao Guangrong [off-list ref] wrote:
quoted
- Convert NAPI's tracepoint via TRACE_EVENT macro, the output information
  like below:
I think as long as it does not touch tracing infrastructure (which 
your patches dont do in their current form) this should be 
done/merged via the networking tree.
I agree, all changes that are in include/trace/events/ and trace point 
usage can stay within the subsystem tree.
quoted
[ There might be some small collisions in define_trace.h (because
  these tracepoints move from legacy to new-style TRACE_EVENT() 
  form) but that's OK. ]
But changes to anything in include/trace or kernel/trace needs to go 
throught the tracing subsystem. This includes a changes to define_trace.h.
This patch can't be split up, so I'm wondering how you suggest to
handle this patch given that you have declared that define_trace.h
changes aren't to go through the subsystem tree?

If we do the define_trace.h change only, we break the build
(lack of macro defined for the trace).

If we do only the other parts of his patch, we get a duplicate
definition.

And keep in mind that Neil and Xiao are probably going to want to do
work on top of this to the networking bits.  Thus if we put this patch
here into the tracing tree, I'll have to develop a dependency on the
tracing tree and I think that will go over like a fart in a spacesuit
with the -next crowd and Stephen Rothwell in particular.

Please advise.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help