Thread (20 messages) 20 messages, 5 authors, 2009-09-30

Re: [PATCH] ax25: Add missing dev_put in ax25_setsockopt

From: David Miller <davem@davemloft.net>
Date: 2009-09-28 19:26:19
Also in: linux-hams

From: Ralf Baechle <redacted>
Date: Mon, 28 Sep 2009 13:53:13 +0100
ax25_setsockopt SO_BINDTODEVICE is missing a dev_put call in case of
success.  Re-order code to fix this bug.  While at it also reformat two
lines of code to comply with the Linux coding style.

Initial patch by Jarek Poplawski [off-list ref].

Reported-by: Bernard Pidoux F6BVP <redacted>
Signed-off-by: Ralf Baechle <redacted>

---
Counter-proposal.  Reordering all the code avoids the need for a 2nd dev_put
and is more readable.
Looks good to me, applied.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help