On Fri, 2009-09-25 at 15:12 -0700, Ben Greear wrote:

On 09/25/2009 03:01 PM, Herbert Xu wrote:

quoted

On Fri, Sep 25, 2009 at 02:59:15PM -0700, David Miller wrote:

quoted

From: Ben Greear<redacted>
Date: Fri, 25 Sep 2009 14:50:44 -0700

quoted

I get aggregate 18Gbps with LRO v/s 12Gbps without, so it's very
much a useful feature for me.

And it'll stay like that until you work with Herbert to fix
that performance difference.

Actually I believe he's talking about hardware LRO which is a
different beast.

AFAICS the ixgbe driver doesn't use software LRO anymore.

So if it is hardware LRO then what we need is for the hardware
to switch over :)

Either way, I will be happy to test & benchmark patches of this nature
if someone wants to post them.

I can't post a patch that changes my hardware behavior.  :-)

So to be clear, ixgbe uses GRO, and does not use software LRO.  In 82599
adapters, we have a HW LRO engine.  So we run HW LRO and GRO together.
What Herbert is referring to is that we change our HW design of the HW
LRO engine to do more of what GRO is doing today.  That would require a
silicon spin, so that wouldn't happen soon unfortunately.

-PJ