Re: [PATCH] tunnel: eliminate recursion field
From: Herbert Xu <herbert@gondor.apana.org.au>
Date: 2009-09-25 21:51:10
From: Herbert Xu <herbert@gondor.apana.org.au>
Date: 2009-09-25 21:51:10
Eric Dumazet [off-list ref] wrote:
It seems recursion field from "struct ip_tunnel" is not anymore needed. recursion prevention is done at the upper level (in dev_queue_xmit()), since we use HARD_TX_LOCK protection for tunnels.
What if we get async processing in between, e.g., nf_queue? In that case we could end up with a packet that went round and around until it exceeded the MTU. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} [off-list ref] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt