From: David Miller <davem@davemloft.net>
Date: Fri, 11 Sep 2009 12:37:25 -0700 (PDT)

From: Roel Kluin <redacted>
Date: Sat, 05 Sep 2009 14:35:18 +0200

quoted

he_dev->rbps_virt or he_dev->rbpl_virt allocation may fail, so check
them. Make sure that he_init_group() cleans up after errors.

Signed-off-by: Roel Kluin <redacted>
---

quoted

These new return statements will both leak resources allocated
earlier.

All the caller is going to do is return -ENOMEM as well and
it does not cleanup actions at all.

Please fix this up.

I am new to this api, so please review.

Looks ok, applied, thanks.

Sorry I have to revert, you didn't even build test this.

Roel, I know you want me to take your changes serious, but I
absolutely cannot when you do stuff like this.