Re: [PATCH] r8169: Reduce looping in the interrupt handler.
From: David Dillow <dave@thedillows.org>
Date: 2009-08-28 01:29:42
Also in:
lkml
Possibly related (same subject, not in this thread)
- 2009-09-01 · Re: [PATCH] r8169: Reduce looping in the interrupt handler. · Francois Romieu <romieu@fr.zoreil.com>
- 2009-09-01 · Re: [PATCH] r8169: Reduce looping in the interrupt handler. · David Dillow <dave@thedillows.org>
- 2009-08-30 · Re: [PATCH] r8169: Reduce looping in the interrupt handler. · Eric W. Biederman <hidden>
- 2009-08-27 · Re: [PATCH] r8169: Reduce looping in the interrupt handler. · Francois Romieu <romieu@fr.zoreil.com>
- 2009-08-27 · Re: [PATCH] r8169: Reduce looping in the interrupt handler. · Eric W. Biederman <hidden>
On Thu, 2009-08-27 at 18:17 -0700, Eric W. Biederman wrote:
Francois Romieu [off-list ref] writes:quoted
Eric W. Biederman [off-list ref] : [...]quoted
Sounds good.Gah, I was not able to test it with a decent packet load. Patch below against the current tree:This kills the loop which was my concern. I will double check it works on my configuration. Then we have the question of does it work for those folks who have cards where the msi appeared to get lost. David any chance you can test this patch?
It'll be this weekend, but I can see cases where it can lock my chip up -- they should be rare, but then I thought your case would be extremely rare... I think we'll need to go to a full separation between MSI and level-triggered interrupt handlers, or at the very least mask everything and handle it all in NAPI. That seems more viable now that I know Francois is not terribly worried about diverging from the vendor driver there.