Re: [PATCH] drivers/net/wireless/ath/ath5k: Change constant name
From: Bob Copeland <hidden>
Date: 2009-08-08 16:21:13
Also in:
kernel-janitors, linux-wireless, lkml
On Sat, Aug 08, 2009 at 03:22:26PM +0200, Julia Lawall wrote:
From: Julia Lawall <redacted> Elsewhere, the tqi_type field is compared to constants having a name beginning with AR5K_TX_QUEUE, rather than AR5K_TX_QUEUE_ID. I have thus converted AR5K_TX_QUEUE_ID_CAB to AR5K_TX_QUEUE_CAB. This does, however, change the value, so perhaps something else was wanted. Signed-off-by: Julia Lawall <redacted>
Nice catch, thanks. Shouldn't cause any problem with 2.6.31 since we don't use the CAB queue yet, but it was definitely wrong. Acked-by: Bob Copeland <me-aXfl/3sk2vNUbtYUoyoikg@public.gmane.org>
quoted hunk
diff --git a/drivers/net/wireless/ath/ath5k/qcu.c b/drivers/net/wireless/ath/ath5k/qcu.c index 6d5aaf0..eeebb9a 100644 --- a/drivers/net/wireless/ath/ath5k/qcu.c +++ b/drivers/net/wireless/ath/ath5k/qcu.c@@ -362,7 +362,7 @@ int ath5k_hw_reset_tx_queue(struct ath5k_hw *ah, unsigned int queue) } if (tq->tqi_ready_time && - (tq->tqi_type != AR5K_TX_QUEUE_ID_CAB)) + (tq->tqi_type != AR5K_TX_QUEUE_CAB)) ath5k_hw_reg_write(ah, AR5K_REG_SM(tq->tqi_ready_time, AR5K_QCU_RDYTIMECFG_INTVAL) | AR5K_QCU_RDYTIMECFG_ENABLE,
-- Bob Copeland %% www.bobcopeland.com