Thread (7 messages) 7 messages, 4 authors, 2009-08-31

Re: [RFC PATCH] sched: Fix resource limiting in pfifo_fast

From: David Miller <davem@davemloft.net>
Date: 2009-08-31 05:19:45

From: Krishna Kumar <redacted>
Date: Sun, 30 Aug 2009 11:53:44 +0530
From: Krishna Kumar <redacted>

pfifo_fast_enqueue has this check:
        if (skb_queue_len(list) < qdisc_dev(qdisc)->tx_queue_len) {

which allows each band to enqueue upto tx_queue_len skbs for a
total of 3*tx_queue_len skbs. I am not sure if this was the
intention of limiting in qdisc.

Patch compiled and 32 simultaneous netperf testing ran fine. Also:
# tc -s qdisc show dev eth2
qdisc pfifo_fast 0: root bands 3 priomap  1 2 2 2 1 2 0 0 1 1 1 1 1 1 1 1
 Sent 16835026752 bytes 373116 pkt (dropped 0, overlimits 0 requeues 25) 
 rate 0bit 0pps backlog 0b 0p requeues 25 

(I am taking next week off, so sorry for any delay in responding)

Signed-off-by: Krishna Kumar <redacted>
This is probably just a thinko, nice catch.

I think I'll apply this to net-next-2.6, thanks!
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help