Thread (1 message) 1 message, 1 author, 2009-08-26

Re: [PATCH 1/1] iwmc3200: add more SDIO device ids

From: Holger Schurig <hidden>
Date: 2009-08-26 07:25:03
Also in: linux-wireless

Possibly related (same subject, not in this thread)

On Tuesday 25 August 2009 01:21:58 Marcel Holtmann wrote:
My personal vote is for keeping all IDs inside the drivers.
And I also prefer to keep the plain hex values and just put a
comment above them which device this is. Something like this:

static struct usb_device_id btusb_table[] = {
	/* Generic Bluetooth USB device */
	{ USB_DEVICE_INFO(0xe0, 0x01, 0x01) },
+1

When I have an unknown device (and not compiled all modules) it's 
so much easier to do an

grep -ri 057c drivers/usb

then to do the same on include/ and then again to find the driver 
that uses this id. For the same reason, I prefer 0x057c in the 
source and not 0x57c.

-- 
http://www.holgerschurig.de
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help