Thread (3 messages) flat view 3 messages, 2 authors, 2009-08-20

Re: [RFC][PATCH][v4] net/ethtool: Add support for the ethtool feature to flash firmware image from a specified file.

From: Ben Hutchings <hidden>
Date: 2009-08-20 17:24:36

On Thu, 2009-08-20 at 22:46 +0530, Ajit Khaparde wrote:
[...]
quoted hunk ↗ jump to hunk
@@ -489,6 +501,7 @@ struct ethtool_ops {
 	int	(*get_stats_count)(struct net_device *);/* use get_sset_count */
 	int	(*get_rxnfc)(struct net_device *, struct ethtool_rxnfc *, void *);
 	int	(*set_rxnfc)(struct net_device *, struct ethtool_rxnfc *);
+	int     (*flash_device)(struct net_device *, u8 *);
[...]

The second parameter type should be struct ethtool_flash * not u8 *.
The compiler warning should make this easy to spot...

Ben.

-- 
Ben Hutchings, Senior Software Engineer, Solarflare Communications
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help