Re: [PATCH] WAN: bit and/or confusion
From: David Miller <davem@davemloft.net>
Date: 2009-08-14 23:41:12
From: David Miller <davem@davemloft.net>
Date: 2009-08-14 23:41:12
From: Andrew Morton <akpm@linux-foundation.org> Date: Fri, 14 Aug 2009 16:36:44 -0700
On Fri, 14 Aug 2009 14:51:46 +0200 Roel Kluin [off-list ref] wrote:quoted
@@ -663,9 +663,9 @@ static inline void dscc4_rx_skb(struct dscc4_dev_priv *dpriv, } else { if (skb->data[pkt_len] & FrameRdo) dev->stats.rx_fifo_errors++; - else if (!(skb->data[pkt_len] | ~FrameCrc)) + else if (!(skb->data[pkt_len] & ~FrameCrc)) dev->stats.rx_crc_errors++;that's if (!(x & 0xffffffdf)) which seems peculiar. Should it have been else if (skb->data[pkt_len] & FrameCrc) or else if (!(skb->data[pkt_len] & FrameCrc))
Indeed, I can't tell which variant would be correct. I'm reverting until someone with a datasheet for this chip speaks up :-)