Thread (5 messages) 5 messages, 3 authors, 2009-08-04

Re: [PATCH] sky2: Avoid transmits during sky2_down()

From: Stephen Hemminger <hidden>
Date: 2009-08-03 16:00:13

On Sun, 02 Aug 2009 13:09:12 -0700 (PDT)
David Miller [off-list ref] wrote:
From: Mike McCormack <redacted>
Date: Fri, 31 Jul 2009 20:57:42 +0900
quoted
I am aware you object to storing extra state, but I can't see a way
around this. Without remembering that we're restarting,
netif_wake_queue() is called in the ISR from sky2_tx_complete(), and
netif_tx_lock() is used in sky2_tx_done().  If anybody can see a way
around this, please let me know.
Stephen please do something about this, soon.

Michael has been trying to get this fixed for more than a month, and
if you don't have a better fix like right now then we should put his
fix in for the time being.

Sky2 patches are ones that consistently rot in patchwork and I'd
appreciate if it that trend would cease, thanks.
Well, Mike's next set of patches is great, so the wait was worth it.

Some of us developer's get paid for doing things. There was a little
thing like a major release from our small engineering organization
at Vyatta to get done. Unlike the cushy life at other companies, in
a small company the engineers have to deal with customer issues,
bugzilla bugs.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help