Thread (7 messages) 7 messages, 3 authors, 2009-08-05

Re: neigh_periodic_timer expires too often

From: David Miller <davem@davemloft.net>
Date: 2009-08-03 01:35:45

From: Eric Dumazet <redacted>
Date: Thu, 30 Jul 2009 15:15:07 +0200
[PATCH net-next-2.6] neigh: Convert garbage collection from softirq to workqueue

Current neigh_periodic_timer() function is fired by timer IRQ, and
scans one hash bucket each round (very litle work in fact)

As we are supposed to scan whole hash table in 15 seconds, this means
neigh_periodic_timer() can be fired very often. (depending on the number
of concurrent hash entries we stored in this table)

Converting this to a workqueue permits scanning whole table, minimizing
icache pollution, and firing this work every 15 seconds, independantly
of hash table size.

This 15 seconds delay is not a hard number, as work is a deferrable one.

Signed-off-by: Eric Dumazet <redacted>
Applied to net-next-2.6, thanks!
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help