Thread (4 messages) 4 messages, 2 authors, 2009-07-28

Re: [PATCH 1/2] IPVS: use pr_fmt

From: Joe Perches <joe@perches.com>
Date: 2009-07-28 16:55:25
Also in: lkml, lvs-devel

On Tue, 2009-07-28 at 18:06 +0200, Hannes Eder wrote:
quoted hunk ↗ jump to hunk
While being at it cleanup whitespace.
diff --git a/include/net/ip_vs.h b/include/net/ip_vs.h
index e01cc2d..99f09ab 100644
--- a/include/net/ip_vs.h
+++ b/include/net/ip_vs.h
@@ -99,47 +99,47 @@ static inline const char *ip_vs_dbg_addr(int af, char *buf, size_t buf_len,
 	return &buf[*idx - len];
 }
 
-#define IP_VS_DBG_BUF(level, msg...)			\
-    do {						\
-	    char ip_vs_dbg_buf[160];			\
-	    int ip_vs_dbg_idx = 0;			\
-	    if (level <= ip_vs_get_debug_level())	\
-		    printk(KERN_DEBUG "IPVS: " msg);	\
-    } while (0)
[]
+#define IP_VS_DBG_BUF(level, msg...)				\
+	do {							\
+		char ip_vs_dbg_buf[160];			\
+		int ip_vs_dbg_idx = 0;				\
+		if (level <= ip_vs_get_debug_level())		\
+			pr_debug(msg);				\
I think you should keep printk(KERN_DEBUG...) here and elsewhere.
Unless DEBUG is #defined, this won't print anything.

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help