Re: [PATCH] mISDN: Read buffer overflow
From: Karsten Keil <hidden>
Date: 2009-07-31 14:28:16
On Freitag, 31. Juli 2009 15:43:59 Roel Kluin wrote: Ouch ! Acked-by: Karsten Keil <redacted>
quoted hunk ↗ jump to hunk
Check whether index is within bounds before testing the element. Signed-off-by: Roel Kluin <redacted> ---diff --git a/drivers/isdn/mISDN/l1oip_core.cb/drivers/isdn/mISDN/l1oip_core.c index c3b661a..7e5f30d 100644--- a/drivers/isdn/mISDN/l1oip_core.c +++ b/drivers/isdn/mISDN/l1oip_core.c@@ -1480,7 +1480,7 @@ l1oip_init(void) return -ENOMEM; l1oip_cnt = 0; - while (type[l1oip_cnt] && l1oip_cnt < MAX_CARDS) { + while (l1oip_cnt < MAX_CARDS && type[l1oip_cnt]) { switch (type[l1oip_cnt] & 0xff) { case 1: pri = 0;