Thread (10 messages) 10 messages, 3 authors, 2009-08-02

Re: [PATCH V3] CAN: Add Flexcan CAN controller driver

From: Wolfgang Grandegger <hidden>
Date: 2009-07-30 20:22:14

Wolfgang Grandegger wrote:
Sascha Hauer wrote:
[...]
quoted
	errcnt = readl(&regs->errcnt);
	rxerr = (errcnt >> 8) & 0xff;
	txerr = errcnt & 0xff;
	if ((rxerr >= 96 || txerr >= 96) && state == CAN_STATE_ERROR_ACTIVE)
		state = CAN_STATE_ERROR_WARNING;
Yes, or do not handle the state in the "case 0" above appropriately. The
CAN spec only specifies the bus error states error active, error passive
and bus off. The warning is somehow optional but available on most CAN
controllers. Nevertheless, we should create a message if the ISR
realizes a state changes.
FYI, I will be on holiday for the next 1.5 weeks.

Wolfgang.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help