Re: [PATCH] net: net_assign_generic() fix
From: Pavel Emelyanov <hidden>
Date: 2009-07-28 13:03:10
Hmm... Real bug may be fixed by followed patch ? (yet untested, sorry...) [PATCH] net: net_assign_generic() fix memcpy() should take into account size of pointers, not only number of pointers to copy. Signed-off-by: Eric Dumazet <redacted>
Acked-by: Pavel Emelyanov <redacted>
quoted hunk ↗ jump to hunk
---diff --git a/net/core/net_namespace.c b/net/core/net_namespace.c index b7292a2..1972830 100644 --- a/net/core/net_namespace.c +++ b/net/core/net_namespace.c@@ -488,7 +488,7 @@ int net_assign_generic(struct net *net, int id, void *data) */ ng->len = id; - memcpy(&ng->ptr, &old_ng->ptr, old_ng->len); + memcpy(&ng->ptr, &old_ng->ptr, old_ng->len * sizeof(void*)); rcu_assign_pointer(net->gen, ng); call_rcu(&old_ng->rcu, net_generic_release);