Re: [PATCH] net: shrink net_device by #ifdef-ing protocol-specific members
From: Joe Perches <joe@perches.com>
Date: 2009-07-27 16:23:05
From: Joe Perches <joe@perches.com>
Date: 2009-07-27 16:23:05
On Mon, 2009-07-27 at 08:26 -0700, David Miller wrote:
From: Lucian Adrian Grijincu <redacted> Date: Mon, 27 Jul 2009 18:09:08 +0300quoted
Some members of net_device are used only by some protocols. If those protocols are not compiled (as modules or linked in) they should not take up space in the structure.This benefits, at best, %0.000000001 of users of the Linux kernel, because every distribution is going to turn on every single option.
I think the cost of maintaining this is small and the percentage of users that benefit underestimated. It does help handsets a trivial amount, which are unlikely to ever enable decnet or econet.
If you want to shrink structures, find ways to eliminate or shrink structure members in all cases.
Good advice.