Thread (8 messages) 8 messages, 3 authors, 2009-06-07

Re: [PATCH 0/3] isdn: patches for 2.6.31

From: David Miller <davem@davemloft.net>
Date: 2009-06-01 10:04:44
Also in: lkml

From: Tilman Schmidt <redacted>
Date: Sun, 31 May 2009 01:32:04 +0200 (CEST)
I would like to propose the following three patches to the Kernel CAPI
subsystem for inclusion in kernel release 2.6.31.
The first one was proposed four weeks ago and so far hasn't met any
protests.
The second one is a rather trivial bugfix and documentation improvement.
The third one just adds a few new insights about the workings of the
CAPI subsystem to the Documentation file, INTERFACE.CAPI.
I'm not applying this patch series.

Especially I dislike the second patch.

First problem in the second patch.  You're doing two things
at once.  You're adding function documentation and also adding
a NULL pointer check.

Second problem, the NULL pointer check is gratuitous.  Document
that the 'm' member has to be non-NULL and leave the check out.

Thanks.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help