Re: [PATCH] sctp: xmit sctp packet always return no route error
From: Vlad Yasevich <hidden>
Date: 2009-06-29 13:12:52
Wei Yongjun wrote:
Commit 'net: skb->dst accessors'(adf30907d63893e4208dfe3f5c88ae12bc2f25d5) broken the sctp protocol stack, the sctp packet can never be sent out after Eric Dumazet's patch, which have typo in the sctp code. Signed-off-by: Wei Yongjun <redacted>
Oh-oh!! Thanks for catching this. Acked-by: Vlad Yasevich <redacted> -vlad
quoted hunk ↗ jump to hunk
--- net/sctp/output.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)diff --git a/net/sctp/output.c b/net/sctp/output.c index b764114..b94c211 100644 --- a/net/sctp/output.c +++ b/net/sctp/output.c@@ -407,7 +407,7 @@ int sctp_packet_transmit(struct sctp_packet *packet) } dst = dst_clone(tp->dst); skb_dst_set(nskb, dst); - if (dst) + if (!dst) goto no_route; /* Build the SCTP header. */