On Mon, 1 Jun 2009, Brian Haley wrote:

David Miller wrote:

quoted

Applied, but really it is tiring fixing up all of the corruptions
your email client made to this patch.

I've had this problem so many times with you that I've totally
lost any hope that you'll be able to submit patches cleanly and
thus I'm resigned to just fix them up every time from now on. :-/

Sorry, I'll start sending them to myself first in the future.  Just reject it
next time and force me to do the work to fix it up as it was my fault.

I also had to edit the patch for linebreaks etc :)

Anyways... when I apply the patch and try too compile, I get:

net/ipv6/addrconf.c: In function 'addrconf_disable_ipv6':
net/ipv6/addrconf.c:4029: error: implicit declaration of function 'restart_syscall'
make[2]: *** [net/ipv6/addrconf.o] Error 1
make[1]: *** [net/ipv6] Error 2


The relevant line is pointed out (->) below:

----
   static int addrconf_disable_ipv6(struct ctl_table *table, int *p, int old)
   {
           struct net *net;
   
           net = (struct net *)table->extra2;
   
           if (p == &net->ipv6.devconf_dflt->disable_ipv6)
                   return 0;
   
           if (!rtnl_trylock())
->                 return restart_syscall();
   
           if (p == &net->ipv6.devconf_all->disable_ipv6) {
                   __s32 newf = net->ipv6.devconf_all->disable_ipv6;
                   net->ipv6.devconf_dflt->disable_ipv6 = newf;
                   addrconf_disable_change(net, newf);
           } else if ((!*p) ^ (!old))
                   dev_disable_change((struct inet6_dev *)table->extra1);
   
           rtnl_unlock();
           return 0;
   }
----

For what it's worth, I'm using gcc 4.3.3.

-- 
Kolbjørn Barmen
UNINETT Driftsenter