Thread (3 messages) flat view 3 messages, 2 authors, 2009-06-02

Re: [PATCH] Fix a race between sky2_down and sky2_poll.

From: Mike McCormack <hidden>
Date: 2009-06-02 06:30:18

Stephen Hemminger wrote:
quoted
-	/* Make sure no packets are pending */
-	napi_synchronize(&hw->napi);
Down is also used during suspend/resume and changing MTU so this needs
more inspection.
Could it be that the real problem is with the non-SMP case for 
napi_synchronize()?  The comment in include/linux/netdevice.h claims 
that napi_synchronize() "Waits till any outstanding processing 
completes..." but the implementation for non-SMP is just a barrier()...

Mike
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help