Re: [PATCH net-next 2/2] cpmac: prevent fatal exception in cpmac_end_xmit
From: David Miller <davem@davemloft.net>
Date: 2009-06-01 09:58:18
From: David Miller <davem@davemloft.net>
Date: 2009-06-01 09:58:18
From: Florian Fainelli <florian@openwrt.org> Date: Sun, 31 May 2009 22:59:15 +0200
From: Stefan Weil <redacted> We should not be stopping the subqueues in cpmac_end_xmit but rather test the status of them. Replace the calls to netif_subqueue_stop by __netif_subqueue_stopped. This fixes an unrecoverable exception from happening when running the driver. Signed-off-by: Stefan Weil <redacted> Signed-off-by: Florian Fainelli <florian@openwrt.org>
Applied, but this commit message was completely wrong and therefore misleading to anyone trying to track down why this change was made. The problem is that netif_subqueue_stopped() takes a SKB pointer, whereas we're passing in an integer queue index here. Therefore, merely providing the obvious compile warning that was produced by this incorrect argument type would have explained everything, and accurately.