Re: [PATCH 4/4] bnx2i: Add bnx2i iSCSI driver.

On Wed, 2009-05-20 at 12:57 -0700, Mike Christie wrote:

Michael Chan wrote:

quoted

diff --git a/include/scsi/iscsi_if.h b/include/scsi/iscsi_if.h
index 2c1a4af..0990dbb 100644
--- a/include/scsi/iscsi_if.h
+++ b/include/scsi/iscsi_if.h

@@ -23,6 +23,9 @@
 

quoted

+ */
+struct iscsi_path {
+	uint64_t	handle;
+	uint8_t		mac_addr[6];
+	uint8_t		mac_addr_old[6];
+	uint32_t	ip_addr_len;	/* 4 or 16 */
+	union {
+		struct in_addr	v4_addr;
+		struct in6_addr	v6_addr;
+	} src;
+	union {
+		struct in_addr	v4_addr;
+		struct in6_addr	v6_addr;

I think we have to include in6.h and in.h in this file, right? iser 
would not compile with this patch without it. If that is right and it 
works for you now, I can just fix it when I merge the patch.

Yes, either include these files here in iscsi_if.h or include them in
places where iscsi_if.h is included.  Which way do you prefer?